Skip to content

Commit

Permalink
[PATCH] drivers/net/wireless/libertas/fw.c: fix use-before-check
Browse files Browse the repository at this point in the history
NULL checks should be performed before the dereference.

Spotted by the Coverity checker.

Signed-off-by: Eugene Teo <eteo@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Eugene Teo authored and John W. Linville committed May 22, 2007
1 parent 3d4bd24 commit 596f2d0
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions drivers/net/wireless/libertas/fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -333,18 +333,22 @@ static void command_timer_fn(unsigned long data)
unsigned long flags;

ptempnode = adapter->cur_cmd;
if (ptempnode == NULL) {
lbs_pr_debug(1, "PTempnode Empty\n");
return;
}

cmd = (struct cmd_ds_command *)ptempnode->bufvirtualaddr;
if (!cmd) {
lbs_pr_debug(1, "cmd is NULL\n");
return;
}

lbs_pr_info("command_timer_fn fired (%x)\n", cmd->command);

if (!adapter->fw_ready)
return;

if (ptempnode == NULL) {
lbs_pr_debug(1, "PTempnode Empty\n");
return;
}

spin_lock_irqsave(&adapter->driver_lock, flags);
adapter->cur_cmd = NULL;
spin_unlock_irqrestore(&adapter->driver_lock, flags);
Expand Down

0 comments on commit 596f2d0

Please sign in to comment.