Skip to content

Commit

Permalink
Merge branch 'tpmdd-next-v3.6' of git://github.com/shpedoikal/linux i…
Browse files Browse the repository at this point in the history
…nto for-linus
  • Loading branch information
James Morris committed Oct 11, 2012
2 parents bb95a0d + abce9ac commit 59b69ac
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions drivers/char/tpm/tpm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1182,17 +1182,20 @@ ssize_t tpm_write(struct file *file, const char __user *buf,
size_t size, loff_t *off)
{
struct tpm_chip *chip = file->private_data;
size_t in_size = size, out_size;
size_t in_size = size;
ssize_t out_size;

/* cannot perform a write until the read has cleared
either via tpm_read or a user_read_timer timeout */
while (atomic_read(&chip->data_pending) != 0)
msleep(TPM_TIMEOUT);

mutex_lock(&chip->buffer_mutex);
either via tpm_read or a user_read_timer timeout.
This also prevents splitted buffered writes from blocking here.
*/
if (atomic_read(&chip->data_pending) != 0)
return -EBUSY;

if (in_size > TPM_BUFSIZE)
in_size = TPM_BUFSIZE;
return -E2BIG;

mutex_lock(&chip->buffer_mutex);

if (copy_from_user
(chip->data_buffer, (void __user *) buf, in_size)) {
Expand All @@ -1202,6 +1205,10 @@ ssize_t tpm_write(struct file *file, const char __user *buf,

/* atomic tpm command send and result receive */
out_size = tpm_transmit(chip, chip->data_buffer, TPM_BUFSIZE);
if (out_size < 0) {
mutex_unlock(&chip->buffer_mutex);
return out_size;
}

atomic_set(&chip->data_pending, out_size);
mutex_unlock(&chip->buffer_mutex);
Expand Down

0 comments on commit 59b69ac

Please sign in to comment.