Skip to content

Commit

Permalink
[PATCH] skge: rx_reuse called twice
Browse files Browse the repository at this point in the history
In the error case we call skge_rx_reuse twice. This is harmless
but unnecessary.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Stephen Hemminger authored and Jeff Garzik committed Mar 23, 2006
1 parent b5d56dd commit 5a01144
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/skge.c
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ static void skge_rx_setup(struct skge_port *skge, struct skge_element *e,
* Note: DMA address is not changed by chip.
* MTU not changed while receiver active.
*/
static void skge_rx_reuse(struct skge_element *e, unsigned int size)
static inline void skge_rx_reuse(struct skge_element *e, unsigned int size)
{
struct skge_rx_desc *rd = e->desc;

Expand Down Expand Up @@ -2719,8 +2719,7 @@ static int skge_poll(struct net_device *dev, int *budget)
netif_receive_skb(skb);

++work_done;
} else
skge_rx_reuse(e, skge->rx_buf_size);
}
}
ring->to_clean = e;

Expand Down

0 comments on commit 5a01144

Please sign in to comment.