Skip to content

Commit

Permalink
[netdrvr] typhoon: typhoon_resume - remove call to start_queue
Browse files Browse the repository at this point in the history
While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
I looked at a few other drivers to figure out what drivers _should_
be doing for suspend/resume. I noticed typhoon driver is likely doing
more than it needs to.  Patch below is untested since I don't have the HW.

Suspend/resume code across NIC drivers is fairly inconsistent.
And I couldn't find any documentation on what the canonical sequence
NICs need to do for suspend or resume.  Is there any?

Barring contrary advice, I'm going model the tulip suspend/resume
fixes after tg3.c since a number of "modern" (< 5 years old) laptops
have that and I'm silly enough to assume it works.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Grant Grundler authored and Jeff Garzik committed Apr 25, 2008
1 parent 11121e3 commit 5a0e2cd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/typhoon.c
Original file line number Diff line number Diff line change
Expand Up @@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
}

netif_device_attach(dev);
netif_start_queue(dev);
return 0;

reset:
Expand Down

0 comments on commit 5a0e2cd

Please sign in to comment.