Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 142841
b: refs/heads/master
c: 700b672
h: refs/heads/master
i:
  142839: 90f7c7e
v: v3
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Apr 7, 2009
1 parent 6dbe998 commit 5a49d7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 25 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7015558fca5ee82fc17227b61d88ddaa02d82242
refs/heads/master: 700b6721cd1b891b67c2dcee046be12154a21fd6
28 changes: 4 additions & 24 deletions trunk/drivers/platform/x86/fujitsu-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ struct led_classdev kblamps_led = {
static u32 dbg_level = 0x03;
#endif

static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data);
static void acpi_fujitsu_notify(struct acpi_device *device, u32 event);

/* Fujitsu ACPI interface function */

Expand Down Expand Up @@ -658,7 +658,6 @@ static struct dmi_system_id fujitsu_dmi_table[] = {

static int acpi_fujitsu_add(struct acpi_device *device)
{
acpi_status status;
acpi_handle handle;
int result = 0;
int state = 0;
Expand All @@ -673,20 +672,10 @@ static int acpi_fujitsu_add(struct acpi_device *device)
sprintf(acpi_device_class(device), "%s", ACPI_FUJITSU_CLASS);
device->driver_data = fujitsu;

status = acpi_install_notify_handler(device->handle,
ACPI_DEVICE_NOTIFY,
acpi_fujitsu_notify, fujitsu);

if (ACPI_FAILURE(status)) {
printk(KERN_ERR "Error installing notify handler\n");
error = -ENODEV;
goto err_stop;
}

fujitsu->input = input = input_allocate_device();
if (!input) {
error = -ENOMEM;
goto err_uninstall_notify;
goto err_stop;
}

snprintf(fujitsu->phys, sizeof(fujitsu->phys),
Expand Down Expand Up @@ -743,28 +732,20 @@ static int acpi_fujitsu_add(struct acpi_device *device)
end:
err_free_input_dev:
input_free_device(input);
err_uninstall_notify:
acpi_remove_notify_handler(device->handle, ACPI_DEVICE_NOTIFY,
acpi_fujitsu_notify);
err_stop:

return result;
}

static int acpi_fujitsu_remove(struct acpi_device *device, int type)
{
acpi_status status;
struct fujitsu_t *fujitsu = NULL;

if (!device || !acpi_driver_data(device))
return -EINVAL;

fujitsu = acpi_driver_data(device);

status = acpi_remove_notify_handler(fujitsu->acpi_handle,
ACPI_DEVICE_NOTIFY,
acpi_fujitsu_notify);

if (!device || !acpi_driver_data(device))
return -EINVAL;

Expand All @@ -775,7 +756,7 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)

/* Brightness notify */

static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data)
static void acpi_fujitsu_notify(struct acpi_device *device, u32 event)
{
struct input_dev *input;
int keycode;
Expand Down Expand Up @@ -829,8 +810,6 @@ static void acpi_fujitsu_notify(acpi_handle handle, u32 event, void *data)
input_report_key(input, keycode, 0);
input_sync(input);
}

return;
}

/* ACPI device for hotkey handling */
Expand Down Expand Up @@ -1107,6 +1086,7 @@ static struct acpi_driver acpi_fujitsu_driver = {
.ops = {
.add = acpi_fujitsu_add,
.remove = acpi_fujitsu_remove,
.notify = acpi_fujitsu_notify,
},
};

Expand Down

0 comments on commit 5a49d7f

Please sign in to comment.