Skip to content

Commit

Permalink
Staging: rt2870: disable root hack for reading files
Browse files Browse the repository at this point in the history
We are now using credentials, so just blindly setting the fsuid and
fsguid isn't acceptable.  All this means is that the config file needs
to be readable by the driver thread, not a big deal.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jan 6, 2009
1 parent c55519f commit 5a501b3
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions drivers/staging/rt2870/rt_profile.c
Original file line number Diff line number Diff line change
Expand Up @@ -925,9 +925,11 @@ NDIS_STATUS RTMPReadParametersHook(

// Save uid and gid used for filesystem access.
// Set user and group to 0 (root)
orgfsuid = current->fsuid;
orgfsgid = current->fsgid;
current->fsuid=current->fsgid = 0;
orgfsuid = current_fsuid();
orgfsgid = current_fsgid();
/* Hm, can't really do this nicely anymore, so rely on these files
* being set to the proper permission to read them... */
/* current->cred->fsuid = current->cred->fsgid = 0; */
orgfs = get_fs();
set_fs(KERNEL_DS);

Expand Down Expand Up @@ -1590,8 +1592,10 @@ NDIS_STATUS RTMPReadParametersHook(
}

set_fs(orgfs);
#if 0
current->fsuid = orgfsuid;
current->fsgid = orgfsgid;
#endif

kfree(buffer);
kfree(tmpbuf);
Expand Down

0 comments on commit 5a501b3

Please sign in to comment.