Skip to content

Commit

Permalink
backlight: lms283gf05: use devm_gpio_request_one
Browse files Browse the repository at this point in the history
By using devm_gpio_request_one it is possible to set the direction
and initial value in one shot. Thus, using devm_gpio_request_one
can make the code simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jingoo Han authored and Linus Torvalds committed Dec 18, 2012
1 parent 9a8fe5d commit 5a5a074
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/video/backlight/lms283gf05.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,9 @@ static int lms283gf05_probe(struct spi_device *spi)
int ret = 0;

if (pdata != NULL) {
ret = devm_gpio_request(&spi->dev, pdata->reset_gpio,
"LMS285GF05 RESET");
if (ret)
return ret;

ret = gpio_direction_output(pdata->reset_gpio,
!pdata->reset_inverted);
ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
GPIOF_DIR_OUT | !pdata->reset_inverted,
"LMS285GF05 RESET");
if (ret)
return ret;
}
Expand Down

0 comments on commit 5a5a074

Please sign in to comment.