Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 199856
b: refs/heads/master
c: 75de46b
h: refs/heads/master
v: v3
  • Loading branch information
Nick Piggin authored and Greg Kroah-Hartman committed Jun 4, 2010
1 parent 9bad214 commit 5a61650
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 743db2d903bc4e963a31496328d847d69f75047c
refs/heads/master: 75de46b98dda624397ccb17c106e51f478a79c15
9 changes: 4 additions & 5 deletions trunk/fs/configfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
if (!sd)
return -EINVAL;

error = simple_setattr(dentry, iattr);
if (error)
return error;

sd_iattr = sd->s_iattr;
if (!sd_iattr) {
/* setting attributes for the first time, allocate now */
Expand All @@ -89,9 +85,12 @@ int configfs_setattr(struct dentry * dentry, struct iattr * iattr)
sd_iattr->ia_atime = sd_iattr->ia_mtime = sd_iattr->ia_ctime = CURRENT_TIME;
sd->s_iattr = sd_iattr;
}

/* attributes were changed atleast once in past */

error = simple_setattr(dentry, iattr);
if (error)
return error;

if (ia_valid & ATTR_UID)
sd_iattr->ia_uid = iattr->ia_uid;
if (ia_valid & ATTR_GID)
Expand Down
6 changes: 4 additions & 2 deletions trunk/fs/sysfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,13 @@ int sysfs_setattr(struct dentry *dentry, struct iattr *iattr)
if (error)
goto out;

error = sysfs_sd_setattr(sd, iattr);
if (error)
goto out;

/* this ignores size changes */
generic_setattr(inode, iattr);

error = sysfs_sd_setattr(sd, iattr);

out:
mutex_unlock(&sysfs_mutex);
return error;
Expand Down

0 comments on commit 5a61650

Please sign in to comment.