Skip to content

Commit

Permalink
ext3: remove unnecessary dentry_unhash on rmdir/rename_dir
Browse files Browse the repository at this point in the history
ext3 has no problems with lingering references to unlinked directory
inodes.

CC: Jan Kara <jack@suse.cz>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Andreas Dilger <adilger.kernel@dilger.ca>
CC: linux-ext4@vger.kernel.org
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Sage Weil authored and Al Viro committed May 26, 2011
1 parent 40ebc0a commit 5a61a24
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/ext3/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -2074,8 +2074,6 @@ static int ext3_rmdir (struct inode * dir, struct dentry *dentry)
struct ext3_dir_entry_2 * de;
handle_t *handle;

dentry_unhash(dentry);

/* Initialize quotas before so that eventual writes go in
* separate transaction */
dquot_initialize(dir);
Expand Down Expand Up @@ -2298,9 +2296,6 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
struct ext3_dir_entry_2 * old_de, * new_de;
int retval, flush_file = 0;

if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
dentry_unhash(new_dentry);

dquot_initialize(old_dir);
dquot_initialize(new_dir);

Expand Down

0 comments on commit 5a61a24

Please sign in to comment.