Skip to content

Commit

Permalink
sungem: Fix WakeOnLan
Browse files Browse the repository at this point in the history
WakeOnLan was broken in this driver because gp->asleep_wol is a 1-bit
bitfield and it was being assigned WAKE_MAGIC, which is (1 << 5).
gp->asleep_wol remains 0 and the machine never wakes up.  Fixed by casting
gp->wake_on_lan to bool.  Tested on an iBook G4.

Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Gerard Lledo authored and David S. Miller committed May 3, 2012
1 parent b49960a commit 5a8887d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/sun/sungem.c
Original file line number Diff line number Diff line change
Expand Up @@ -2339,7 +2339,7 @@ static int gem_suspend(struct pci_dev *pdev, pm_message_t state)
netif_device_detach(dev);

/* Switch off chip, remember WOL setting */
gp->asleep_wol = gp->wake_on_lan;
gp->asleep_wol = !!gp->wake_on_lan;
gem_do_stop(dev, gp->asleep_wol);

/* Unlock the network stack */
Expand Down

0 comments on commit 5a8887d

Please sign in to comment.