Skip to content

Commit

Permalink
staging: brcm80211: remove fullmac module_param for ARP offload feature
Browse files Browse the repository at this point in the history
Use macro to replace global variable for ARP offload configuration

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Franky Lin authored and Greg Kroah-Hartman committed Sep 16, 2011
1 parent 8e11850 commit 5a8dc2e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 22 deletions.
10 changes: 0 additions & 10 deletions drivers/staging/brcm80211/brcmfmac/dhd.h
Original file line number Diff line number Diff line change
Expand Up @@ -665,16 +665,6 @@ struct bcmevent_name {
const char *name;
};

/*
* Insmod parameters for debug/test
*/

/* ARP offload agent mode */
extern uint brcmf_arp_mode;

/* ARP offload enable */
extern uint brcmf_arp_enable;

/* Override to force tx queueing all the time */
extern uint brcmf_force_tx_queueing;

Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/brcm80211/brcmfmac/dhd_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#define DOT11_OUI_LEN 3
#define BCMILCP_BCM_SUBTYPE_EVENT 1
#define PKTFILTER_BUF_SIZE 2048
#define BRCMF_ARPOL_MODE 0xb /* agent|snoop|peer_autoreply */

int brcmf_msg_level;

Expand Down Expand Up @@ -859,9 +860,8 @@ int brcmf_c_preinit_ioctls(struct brcmf_pub *drvr)
(char *)&scan_unassoc_time, sizeof(scan_unassoc_time));

/* Set and enable ARP offload feature */
if (brcmf_arp_enable)
brcmf_c_arp_offload_set(drvr, brcmf_arp_mode);
brcmf_c_arp_offload_enable(drvr, brcmf_arp_enable);
brcmf_c_arp_offload_set(drvr, BRCMF_ARPOL_MODE);
brcmf_c_arp_offload_enable(drvr, true);

/* Set up pkt filter */
for (i = 0; i < drvr->pktfilter_count; i++) {
Expand Down
9 changes: 0 additions & 9 deletions drivers/staging/brcm80211/brcmfmac/dhd_linux.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,6 @@ struct brcmf_info {
/* Error bits */
module_param(brcmf_msg_level, int, 0);

/* ARP offload agent mode : Enable ARP Host Auto-Reply
and ARP Peer Auto-Reply */
uint brcmf_arp_mode = 0xb;
module_param(brcmf_arp_mode, uint, 0);

/* ARP offload enable */
uint brcmf_arp_enable = true;
module_param(brcmf_arp_enable, uint, 0);

/* Network inteface name */
char iface_name[IFNAMSIZ] = "wlan";
module_param_string(iface_name, iface_name, IFNAMSIZ, 0);
Expand Down

0 comments on commit 5a8dc2e

Please sign in to comment.