Skip to content

Commit

Permalink
vgacon: vgacon_scrolldelta simplification
Browse files Browse the repository at this point in the history
There's no point in checking diff == c->vc_rows, because it can be true
only when count == 0, but we already checked that.  Additionally move
variables used only in one block to this block.

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Marcin Slusarz authored and Linus Torvalds committed Oct 16, 2008
1 parent c38182a commit 5ab4840
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions drivers/video/console/vgacon.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,7 @@ static void vgacon_restore_screen(struct vc_data *c)

static int vgacon_scrolldelta(struct vc_data *c, int lines)
{
int start, end, count, soff, diff;
void *d, *s;
int start, end, count, soff;

if (!lines) {
c->vc_visible_origin = c->vc_origin;
Expand Down Expand Up @@ -287,13 +286,13 @@ static int vgacon_scrolldelta(struct vc_data *c, int lines)
if (count > c->vc_rows)
count = c->vc_rows;

diff = c->vc_rows - count;

d = (void *) c->vc_origin;
s = (void *) c->vc_screenbuf;

if (count) {
int copysize;

int diff = c->vc_rows - count;
void *d = (void *) c->vc_origin;
void *s = (void *) c->vc_screenbuf;

count *= c->vc_size_row;
/* how much memory to end of buffer left? */
copysize = min(count, vgacon_scrollback_size - soff);
Expand All @@ -305,14 +304,11 @@ static int vgacon_scrolldelta(struct vc_data *c, int lines)
scr_memcpyw(d, vgacon_scrollback, count);
d += count;
}
}

if (diff == c->vc_rows) {
vgacon_cursor(c, CM_MOVE);
} else {
if (diff)
scr_memcpyw(d, s, diff * c->vc_size_row);
}
} else
vgacon_cursor(c, CM_MOVE);

return 1;
}
Expand Down

0 comments on commit 5ab4840

Please sign in to comment.