Skip to content

Commit

Permalink
Input: check keycodesize when adjusting keymaps
Browse files Browse the repository at this point in the history
When changing key mappings we need to make sure that the new
keycode value can be stored in dev->keycodesize bytes.

Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Vojtech Pavlik authored and Dmitry Torokhov committed Jul 24, 2005
1 parent 463a4f7 commit 5ac7ba3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/keyboard.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ int setkeycode(unsigned int scancode, unsigned int keycode)

if (scancode >= dev->keycodemax)
return -EINVAL;
if (keycode > KEY_MAX)
return -EINVAL;
if (keycode < 0 || keycode > KEY_MAX)
return -EINVAL;
if (keycode >> (dev->keycodesize * 8))
return -EINVAL;

oldkey = SET_INPUT_KEYCODE(dev, scancode, keycode);

Expand Down
1 change: 1 addition & 0 deletions drivers/input/evdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ static long evdev_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
if (t < 0 || t >= dev->keycodemax || !dev->keycodesize) return -EINVAL;
if (get_user(v, ip + 1)) return -EFAULT;
if (v < 0 || v > KEY_MAX) return -EINVAL;
if (v >> (dev->keycodesize * 8)) return -EINVAL;
u = SET_INPUT_KEYCODE(dev, t, v);
clear_bit(u, dev->keybit);
set_bit(v, dev->keybit);
Expand Down

0 comments on commit 5ac7ba3

Please sign in to comment.