Skip to content

Commit

Permalink
Bias the placement of kernel pages at lower PFNs
Browse files Browse the repository at this point in the history
This patch chooses blocks with lower PFNs when placing kernel allocations.
This is particularly important during fallback in low memory situations to
stop unmovable pages being placed throughout the entire address space.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Mel Gorman authored and Linus Torvalds committed Oct 16, 2007
1 parent 9ef9acb commit 5adc5be
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,23 @@ int move_freepages_block(struct zone *zone, struct page *page, int migratetype)
return move_freepages(zone, start_page, end_page, migratetype);
}

/* Return the page with the lowest PFN in the list */
static struct page *min_page(struct list_head *list)
{
unsigned long min_pfn = -1UL;
struct page *min_page = NULL, *page;;

list_for_each_entry(page, list, lru) {
unsigned long pfn = page_to_pfn(page);
if (pfn < min_pfn) {
min_pfn = pfn;
min_page = page;
}
}

return min_page;
}

/* Remove an element from the buddy allocator from the fallback list */
static struct page *__rmqueue_fallback(struct zone *zone, int order,
int start_migratetype)
Expand Down Expand Up @@ -795,8 +812,11 @@ static struct page *__rmqueue_fallback(struct zone *zone, int order,
if (list_empty(&area->free_list[migratetype]))
continue;

/* Bias kernel allocations towards low pfns */
page = list_entry(area->free_list[migratetype].next,
struct page, lru);
if (unlikely(start_migratetype != MIGRATE_MOVABLE))
page = min_page(&area->free_list[migratetype]);
area->nr_free--;

/*
Expand Down

0 comments on commit 5adc5be

Please sign in to comment.