Skip to content

Commit

Permalink
fix the treatment of jfs special inodes
Browse files Browse the repository at this point in the history
We used to put them on a single list, without any locking.  Racy.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Jan 5, 2009
1 parent d8e9650 commit 5b45d96
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions fs/jfs/jfs_imap.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@

/*
* __mark_inode_dirty expects inodes to be hashed. Since we don't want
* special inodes in the fileset inode space, we hash them to a dummy head
* special inodes in the fileset inode space, we make them appear hashed,
* but do not put on any lists.
*/
static HLIST_HEAD(aggregate_hash);

/*
* imap locks
Expand Down Expand Up @@ -496,7 +496,11 @@ struct inode *diReadSpecial(struct super_block *sb, ino_t inum, int secondary)
/* release the page */
release_metapage(mp);

hlist_add_head(&ip->i_hash, &aggregate_hash);
/*
* that will look hashed, but won't be on any list; hlist_del()
* will work fine and require no locking.
*/
ip->i_hash.pprev = &ip->i_hash.next;

return (ip);
}
Expand Down

0 comments on commit 5b45d96

Please sign in to comment.