Skip to content

Commit

Permalink
drm/i915/dsi: add some constness to vbt panel driver
Browse files Browse the repository at this point in the history
Const is good for you. No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-By: Shobhit Kumar <shobhit.kumar@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Jani Nikula authored and Daniel Vetter committed Jan 27, 2015
1 parent 36d21f4 commit 5b48ca0
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ static inline enum port intel_dsi_seq_port_to_port(u8 port)
return port ? PORT_C : PORT_A;
}

static u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi, u8 *data)
static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
const u8 *data)
{
u8 type, byte, mode, vc, seq_port;
u16 len;
Expand Down Expand Up @@ -165,17 +166,17 @@ static u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi, u8 *data)
return data;
}

static u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, u8 *data)
static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
{
u32 delay = *((u32 *) data);
u32 delay = *((const u32 *) data);

usleep_range(delay, delay + 10);
data += 4;

return data;
}

static u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, u8 *data)
static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
{
u8 gpio, action;
u16 function, pad;
Expand Down Expand Up @@ -208,7 +209,8 @@ static u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, u8 *data)
return data;
}

typedef u8 * (*fn_mipi_elem_exec)(struct intel_dsi *intel_dsi, u8 *data);
typedef const u8 * (*fn_mipi_elem_exec)(struct intel_dsi *intel_dsi,
const u8 *data);
static const fn_mipi_elem_exec exec_elem[] = {
NULL, /* reserved */
mipi_exec_send_packet,
Expand All @@ -232,13 +234,12 @@ static const char * const seq_name[] = {
"MIPI_SEQ_DEASSERT_RESET"
};

static void generic_exec_sequence(struct intel_dsi *intel_dsi, char *sequence)
static void generic_exec_sequence(struct intel_dsi *intel_dsi, const u8 *data)
{
u8 *data = sequence;
fn_mipi_elem_exec mipi_elem_exec;
int index;

if (!sequence)
if (!data)
return;

DRM_DEBUG_DRIVER("Starting MIPI sequence - %s\n", seq_name[*data]);
Expand Down

0 comments on commit 5b48ca0

Please sign in to comment.