Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 123153
b: refs/heads/master
c: ab7476c
h: refs/heads/master
i:
  123151: 302e5a9
v: v3
  • Loading branch information
Arjan van de Ven authored and Ingo Molnar committed Sep 10, 2008
1 parent c40ab9f commit 5b69585
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: fb822db465bd9fd4208eef1af4490539b236c54e
refs/heads/master: ab7476cf76e560f0efda2a631a70aabe93009025
3 changes: 3 additions & 0 deletions trunk/include/linux/kernel.h
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ extern unsigned long long memparse(char *ptr, char **retptr);
extern int core_kernel_text(unsigned long addr);
extern int __kernel_text_address(unsigned long addr);
extern int kernel_text_address(unsigned long addr);
extern int func_ptr_is_kernel_text(void *ptr);
extern void *dereference_function_descriptor(void *ptr);

struct pid;
extern struct pid *session_of_pgrp(struct pid *pgrp);

Expand Down
16 changes: 16 additions & 0 deletions trunk/kernel/extable.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,19 @@ int kernel_text_address(unsigned long addr)
return 1;
return module_text_address(addr) != NULL;
}

/*
* On some architectures (PPC64, IA64) function pointers
* are actually only tokens to some data that then holds the
* real function address. As a result, to find if a function
* pointer is part of the kernel text, we need to do some
* special dereferencing first.
*/
int func_ptr_is_kernel_text(void *ptr)
{
unsigned long addr;
addr = (unsigned long) dereference_function_descriptor(ptr);
if (core_kernel_text(addr))
return 1;
return module_text_address(addr) != NULL;
}
10 changes: 1 addition & 9 deletions trunk/kernel/notifier.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ BLOCKING_NOTIFIER_HEAD(reboot_notifier_list);
static int notifier_chain_register(struct notifier_block **nl,
struct notifier_block *n)
{
if (!kernel_text_address((unsigned long)n->notifier_call)) {
WARN(1, "Invalid notifier registered!");
return 0;
}
while ((*nl) != NULL) {
if (n->priority > (*nl)->priority)
break;
Expand All @@ -38,10 +34,6 @@ static int notifier_chain_register(struct notifier_block **nl,
static int notifier_chain_cond_register(struct notifier_block **nl,
struct notifier_block *n)
{
if (!kernel_text_address((unsigned long)n->notifier_call)) {
WARN(1, "Invalid notifier registered!");
return 0;
}
while ((*nl) != NULL) {
if ((*nl) == n)
return 0;
Expand Down Expand Up @@ -92,7 +84,7 @@ static int __kprobes notifier_call_chain(struct notifier_block **nl,
next_nb = rcu_dereference(nb->next);

#ifdef CONFIG_DEBUG_NOTIFIERS
if (!kernel_text_address((unsigned long)nb->notifier_call)) {
if (unlikely(!func_ptr_is_kernel_text(nb->notifier_call))) {
WARN(1, "Invalid notifier called!");
nb = next_nb;
continue;
Expand Down
2 changes: 1 addition & 1 deletion trunk/lib/vsprintf.c
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ static char *string(char *buf, char *end, char *s, int field_width, int precisio
return buf;
}

static inline void *dereference_function_descriptor(void *ptr)
void *dereference_function_descriptor(void *ptr)
{
#if defined(CONFIG_IA64) || defined(CONFIG_PPC64)
void *p;
Expand Down

0 comments on commit 5b69585

Please sign in to comment.