Skip to content

Commit

Permalink
x86, microcode_amd: fix shift warning
Browse files Browse the repository at this point in the history
microcode_amd.c uses ">> 32" on a 32-bit value, so gcc warns about that.
The code could use something like this *untested* patch.

linux-next-20080821/arch/x86/kernel/microcode_amd.c:229: warning: right shift count >= width of type

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Randy Dunlap authored and Ingo Molnar committed Aug 22, 2008
1 parent d45de40 commit 5b792d3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/x86/kernel/microcode_amd.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ static void apply_microcode_amd(int cpu)
unsigned int rev;
int cpu_num = raw_smp_processor_id();
struct ucode_cpu_info *uci = ucode_cpu_info + cpu_num;
unsigned long addr;

/* We should bind the task to the CPU */
BUG_ON(cpu_num != cpu);
Expand All @@ -215,10 +216,9 @@ static void apply_microcode_amd(int cpu)

spin_lock_irqsave(&microcode_update_lock, flags);

edx = (unsigned int)(((unsigned long)
&(uci->mc.mc_amd->hdr.data_code)) >> 32);
eax = (unsigned int)(((unsigned long)
&(uci->mc.mc_amd->hdr.data_code)) & 0xffffffffL);
addr = (unsigned long)&uci->mc.mc_amd->hdr.data_code;
edx = (unsigned int)(((unsigned long)upper_32_bits(addr)));
eax = (unsigned int)(((unsigned long)lower_32_bits(addr)));

asm volatile("movl %0, %%ecx; wrmsr" :
: "i" (0xc0010020), "a" (eax), "d" (edx) : "ecx");
Expand Down

0 comments on commit 5b792d3

Please sign in to comment.