Skip to content

Commit

Permalink
USB: s3c2410_udc: fix custom UDC command handling
Browse files Browse the repository at this point in the history
There is a bug in Samsung's UDC driver, which is completely disabling
the USB device when a custom UDC command is used.
Following patch seems to get the right behavior (e.g. enabling pull-up
instead of disabling then Vcc is applied).

Signed-off-by: Viliam Mateicka <viliam.mateicka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Viliam Mateicka authored and Greg Kroah-Hartman committed Jul 1, 2011
1 parent bc8687d commit 5b82613
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/gadget/s3c2410_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd)
return;

if (udc_info->udc_command) {
udc_info->udc_command(S3C2410_UDC_P_DISABLE);
udc_info->udc_command(cmd);
} else if (gpio_is_valid(udc_info->pullup_pin)) {
int value;

Expand Down

0 comments on commit 5b82613

Please sign in to comment.