Skip to content

Commit

Permalink
edac, mce: Filter out invalid values
Browse files Browse the repository at this point in the history
Print the CPU associated with the error only when the field is valid.

Cc: <stable@kernel.org> # .32.x .33.x
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
  • Loading branch information
Borislav Petkov committed Mar 22, 2010
1 parent 220bf99 commit 5b89d2f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/edac/edac_mce_amd.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,12 @@ void amd_decode_nb_mce(int node_id, struct err_regs *regs, int handle_errors)
if (regs->nbsh & K8_NBSH_ERR_CPU_VAL)
pr_cont(", core: %u\n", (u8)(regs->nbsh & 0xf));
} else {
pr_cont(", core: %d\n", fls((regs->nbsh & 0xf) - 1));
u8 assoc_cpus = regs->nbsh & 0xf;

if (assoc_cpus > 0)
pr_cont(", core: %d", fls(assoc_cpus) - 1);

pr_cont("\n");
}

pr_emerg("%s.\n", EXT_ERR_MSG(xec));
Expand Down

0 comments on commit 5b89d2f

Please sign in to comment.