Skip to content

Commit

Permalink
[SCSI] remove spurious if tests from scsi_eh_{times_out|done}
Browse files Browse the repository at this point in the history
'if' tests which check if eh_action isn't NULL in both
functions are always true.  Remove the redundant if's as it
can give wrong impressions.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Tejun Heo authored and James Bottomley committed May 20, 2005
1 parent 0155a37 commit 5b8ef84
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/scsi/scsi_error.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,7 @@ static void scsi_eh_times_out(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s: scmd:%p\n", __FUNCTION__,
scmd));

if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action);
up(scmd->device->host->eh_action);
}

/**
Expand All @@ -457,8 +456,7 @@ static void scsi_eh_done(struct scsi_cmnd *scmd)
SCSI_LOG_ERROR_RECOVERY(3, printk("%s scmd: %p result: %x\n",
__FUNCTION__, scmd, scmd->result));

if (scmd->device->host->eh_action)
up(scmd->device->host->eh_action);
up(scmd->device->host->eh_action);
}
}

Expand Down

0 comments on commit 5b8ef84

Please sign in to comment.