Skip to content

Commit

Permalink
TC: Handle device_register() errors.
Browse files Browse the repository at this point in the history
Make the TURBOchannel driver bail out if the call to device_register()
failed.

Signed-off-by: Levente Kurusa <levex@linux.com>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Linux MIPS <linux-mips@linux-mips.org>
Patchwork: https://patchwork.linux-mips.org/patch/6673/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Levente Kurusa authored and Ralf Baechle committed Jun 26, 2014
1 parent ab6c15b commit 5bb7889
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions drivers/tc/tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ static void __init tc_bus_add_devices(struct tc_bus *tbus)

tc_device_get_irq(tdev);

device_register(&tdev->dev);
if (device_register(&tdev->dev)) {
put_device(&tdev->dev);
goto out_err;
}
list_add_tail(&tdev->node, &tbus->devices);

out_err:
Expand All @@ -148,7 +151,10 @@ static int __init tc_init(void)

INIT_LIST_HEAD(&tc_bus.devices);
dev_set_name(&tc_bus.dev, "tc");
device_register(&tc_bus.dev);
if (device_register(&tc_bus.dev)) {
put_device(&tc_bus.dev);
return 0;
}

if (tc_bus.info.slot_size) {
unsigned int tc_clock = tc_get_speed(&tc_bus) / 100000;
Expand Down

0 comments on commit 5bb7889

Please sign in to comment.