Skip to content

Commit

Permalink
[PATCH] x86-64: Use physflat on Intel for < 8 CPUs with CPU hotplug
Browse files Browse the repository at this point in the history
This avoids races with the APIC broadcast/mask modes.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Sep 12, 2005
1 parent 27183eb commit 5bf97e0
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions arch/x86_64/kernel/genapic.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,14 @@ void __init clustered_apic_check(void)
* (We don't use lowest priority delivery + HW APIC IRQ steering, so
* can ignore the clustered logical case and go straight to physical.)
*/
if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster) {
#ifdef CONFIG_HOTPLUG_CPU
/* Don't use APIC shortcuts in CPU hotplug to avoid races */
genapic = &apic_physflat;
#else
genapic = &apic_flat;
else
#endif
} else
genapic = &apic_cluster;

print:
Expand Down

0 comments on commit 5bf97e0

Please sign in to comment.