Skip to content

Commit

Permalink
powerpc: clean-up include ordering in prom.h
Browse files Browse the repository at this point in the history
Now that the core OF headers don't depend on prom.h, rearrange the
includes. There are still lots of implicit includes in the powerpc tree,
so the includes of OF headers are still necessary.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Acked-by: Grant Likely <grant.likely@linaro.org>
  • Loading branch information
Rob Herring committed Oct 10, 2013
1 parent d0dfa16 commit 5c19c5c
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions arch/powerpc/include/asm/prom.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#include <linux/of.h> /* linux/of.h gets to determine #include ordering */
#ifndef _POWERPC_PROM_H
#define _POWERPC_PROM_H
#ifdef __KERNEL__
Expand All @@ -20,6 +19,13 @@
#include <asm/irq.h>
#include <linux/atomic.h>

/* These includes should be removed once implicit includes are cleaned up. */
#include <linux/of.h>
#include <linux/of_fdt.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/platform_device.h>

/*
* OF address retreival & translation
*/
Expand Down Expand Up @@ -125,14 +131,5 @@ struct of_drconf_cell {
*/
extern unsigned char ibm_architecture_vec[];

/* These includes are put at the bottom because they may contain things
* that are overridden by this file. Ideally they shouldn't be included
* by this file, but there are a bunch of .c files that currently depend
* on it. Eventually they will be cleaned up. */
#include <linux/of_fdt.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/platform_device.h>

#endif /* __KERNEL__ */
#endif /* _POWERPC_PROM_H */

0 comments on commit 5c19c5c

Please sign in to comment.