Skip to content

Commit

Permalink
b44: fix force mac address before ifconfig up
Browse files Browse the repository at this point in the history
Initializing the b44 MAC & PCI functional blocks in the controller must
occur inside init_one(). This will allow access to the MAC registers.
The controller was being powered up in b44_open() which would not allow
access to the registers before ifconfig was up.
Philip Kohlbecher found this bug.

Signed-off-by: Gary Zambrano <zambrano@broadcom.com>
  • Loading branch information
Gary Zambrano authored and Jeff Garzik committed Mar 29, 2006
1 parent f3cab8a commit 5c51312
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/net/b44.c
Original file line number Diff line number Diff line change
Expand Up @@ -2033,6 +2033,11 @@ static int __devinit b44_init_one(struct pci_dev *pdev,

pci_save_state(bp->pdev);

/* Chip reset provides power to the b44 MAC & PCI cores, which
* is necessary for MAC register access.
*/
b44_chip_reset(bp);

printk(KERN_INFO "%s: Broadcom 4400 10/100BaseT Ethernet ", dev->name);
for (i = 0; i < 6; i++)
printk("%2.2x%c", dev->dev_addr[i],
Expand Down

0 comments on commit 5c51312

Please sign in to comment.