Skip to content

Commit

Permalink
libfs: drop unneeded dentry_unhash
Browse files Browse the repository at this point in the history
There are no libfs issues with dangling references to empty directories.

Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Sage Weil authored and Al Viro committed May 26, 2011
1 parent a71905f commit 5c5d3f3
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/libfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,6 @@ int simple_rmdir(struct inode *dir, struct dentry *dentry)
if (!simple_empty(dentry))
return -ENOTEMPTY;

dentry_unhash(dentry);

drop_nlink(dentry->d_inode);
simple_unlink(dir, dentry);
drop_nlink(dir);
Expand All @@ -325,9 +323,6 @@ int simple_rename(struct inode *old_dir, struct dentry *old_dentry,
struct inode *inode = old_dentry->d_inode;
int they_are_dirs = S_ISDIR(old_dentry->d_inode->i_mode);

if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
dentry_unhash(new_dentry);

if (!simple_empty(new_dentry))
return -ENOTEMPTY;

Expand Down

0 comments on commit 5c5d3f3

Please sign in to comment.