Skip to content

Commit

Permalink
[PATCH] compile error of register_memory()
Browse files Browse the repository at this point in the history
register_memory() becomes double definition in 2.6.20-rc1.  It is defined
in arch/i386/kernel/setup.c as static definition in 2.6.19.  But it is
moved to arch/i386/kernel/e820.c in 2.6.20-rc1.  And same name function is
defined in driver/base/memory.c too.  So, it becomes cause of compile error
of duplicate definition if memory hotplug option is on.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Yasunori Goto authored and Linus Torvalds committed Dec 22, 2006
1 parent 561ccd3 commit 5c95da9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/e820.c
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ void __init register_bootmem_low_pages(unsigned long max_low_pfn)
}
}

void __init register_memory(void)
void __init e820_register_memory(void)
{
unsigned long gapstart, gapsize, round;
unsigned long long last;
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ void __init setup_arch(char **cmdline_p)
get_smp_config();
#endif

register_memory();
e820_register_memory();

#ifdef CONFIG_VT
#if defined(CONFIG_VGA_CONSOLE)
Expand Down
2 changes: 1 addition & 1 deletion include/asm-i386/e820.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ extern int e820_all_mapped(unsigned long start, unsigned long end,
unsigned type);
extern void find_max_pfn(void);
extern void register_bootmem_low_pages(unsigned long max_low_pfn);
extern void register_memory(void);
extern void e820_register_memory(void);
extern void limit_regions(unsigned long long size);
extern void print_memory_map(char *who);

Expand Down

0 comments on commit 5c95da9

Please sign in to comment.