Skip to content

Commit

Permalink
staging:iio: Move event attributes into the event[n] device in sysfs
Browse files Browse the repository at this point in the history
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jonathan Cameron authored and Greg Kroah-Hartman committed May 11, 2010
1 parent 5aaaeba commit 5cba220
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions drivers/staging/iio/industrialio-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -676,16 +676,14 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)
dev_info->event_interfaces[i].id);
goto error_free_setup_ev_ints;
}
}

for (i = 0; i < dev_info->num_interrupt_lines; i++) {
snprintf(dev_info->event_interfaces[i]._attrname, 20,
"event_line%d_sources", i);
dev_info->event_attrs[i].name
= (const char *)
(dev_info->event_interfaces[i]._attrname);
ret = sysfs_create_group(&dev_info->dev.kobj,
&dev_info->event_attrs[i]);
dev_set_drvdata(&dev_info->event_interfaces[i].dev,
(void *)dev_info);
ret = sysfs_create_group(&dev_info
->event_interfaces[i]
.dev.kobj,
&dev_info->event_attrs[i]);

if (ret) {
dev_err(&dev_info->dev,
"Failed to register sysfs for event attrs");
Expand All @@ -707,13 +705,13 @@ static int iio_device_register_eventset(struct iio_dev *dev_info)
i = dev_info->num_interrupt_lines - 1;
error_remove_sysfs_interfaces:
for (j = 0; j < i; j++)
sysfs_remove_group(&dev_info->dev.kobj,
sysfs_remove_group(&dev_info
->event_interfaces[j].dev.kobj,
&dev_info->event_attrs[j]);
i = dev_info->num_interrupt_lines - 1;
error_free_setup_ev_ints:
for (j = 0; j < i; j++) {
iio_free_idr_val(&iio_event_idr,
dev_info->event_interfaces[i].id);
dev_info->event_interfaces[j].id);
iio_free_ev_int(&dev_info->event_interfaces[j]);
}
kfree(dev_info->interrupts);
Expand All @@ -731,7 +729,8 @@ static void iio_device_unregister_eventset(struct iio_dev *dev_info)
if (dev_info->num_interrupt_lines == 0)
return;
for (i = 0; i < dev_info->num_interrupt_lines; i++)
sysfs_remove_group(&dev_info->dev.kobj,
sysfs_remove_group(&dev_info
->event_interfaces[i].dev.kobj,
&dev_info->event_attrs[i]);

for (i = 0; i < dev_info->num_interrupt_lines; i++) {
Expand Down

0 comments on commit 5cba220

Please sign in to comment.