Skip to content

Commit

Permalink
ixgbevf: Fix Oops
Browse files Browse the repository at this point in the history
The driver is calling netif_carrier_off and netif_tx_stop_all_queues
before the netdevice is registered which causes an Oops.  Move call
to netif_carrier_off after the netdevice is registered and remove
call to netif_tx_stop_all_queues because there aren't any TX
queues yet.

Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Greg Rose authored and Jeff Kirsher committed Nov 17, 2010
1 parent e2ddeba commit 5d426ad
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ixgbevf/ixgbevf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3425,10 +3425,6 @@ static int __devinit ixgbevf_probe(struct pci_dev *pdev,
if (hw->mac.ops.get_bus_info)
hw->mac.ops.get_bus_info(hw);


netif_carrier_off(netdev);
netif_tx_stop_all_queues(netdev);

strcpy(netdev->name, "eth%d");

err = register_netdev(netdev);
Expand All @@ -3437,6 +3433,8 @@ static int __devinit ixgbevf_probe(struct pci_dev *pdev,

adapter->netdev_registered = true;

netif_carrier_off(netdev);

ixgbevf_init_last_counter_stats(adapter);

/* print the MAC address */
Expand Down

0 comments on commit 5d426ad

Please sign in to comment.