Skip to content

Commit

Permalink
sound/oss: fix sparse warnings: different signedness
Browse files Browse the repository at this point in the history
Impact: Change signature of 'set_volume_stereo' and 'set_volume_mono'.

Fix this sparse warnings:
  sound/oss/pss.c:545:42: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:546:42: warning: incorrect type in argument 3 (different signedness)
  sound/oss/pss.c:554:59: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:560:59: warning: incorrect type in argument 2 (different signedness)
  sound/oss/pss.c:566:59: warning: incorrect type in argument 2 (different signedness)

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Hannes Eder authored and Takashi Iwai committed Feb 26, 2009
1 parent eca985d commit 5d44aa4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions sound/oss/pss.c
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,9 @@ static void pss_mixer_reset(pss_confdata *devc)
}
}

static int set_volume_mono(unsigned __user *p, int *aleft)
static int set_volume_mono(unsigned __user *p, unsigned int *aleft)
{
int left;
unsigned volume;
unsigned int left, volume;
if (get_user(volume, p))
return -EFAULT;

Expand All @@ -471,10 +470,11 @@ static int set_volume_mono(unsigned __user *p, int *aleft)
return 0;
}

static int set_volume_stereo(unsigned __user *p, int *aleft, int *aright)
static int set_volume_stereo(unsigned __user *p,
unsigned int *aleft,
unsigned int *aright)
{
int left, right;
unsigned volume;
unsigned int left, right, volume;
if (get_user(volume, p))
return -EFAULT;

Expand Down

0 comments on commit 5d44aa4

Please sign in to comment.