Skip to content

Commit

Permalink
firewire: remove bogus check in fw_core_handle_request
Browse files Browse the repository at this point in the history
This check is bogus:
  - Maximum asynchronous payload size for S800...S3200 is 4096.
  - The p->payload_length is totally uninteresting.  Only the
    request->length of the subsequently allocated and initialized
    struct fw_request is of significance.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
  • Loading branch information
Stefan Richter committed Jul 18, 2007
1 parent b980f5a commit 5d59a6f
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/firewire/fw-transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,11 +628,6 @@ fw_core_handle_request(struct fw_card *card, struct fw_packet *p)
unsigned long flags;
int tcode, destination, source;

if (p->payload_length > 2048) {
/* FIXME: send error response. */
return;
}

if (p->ack != ACK_PENDING && p->ack != ACK_COMPLETE)
return;

Expand Down

0 comments on commit 5d59a6f

Please sign in to comment.