Skip to content

Commit

Permalink
IB/qib: Fix size of cc_supported_table_entries
Browse files Browse the repository at this point in the history
Commit 36a8f01 ("IB/qib: Add congestion control agent
implementation") tries to store the value 1984 in a u8, which leads to
truncation.  Fix this by making the member big enough.

This bug was detected by a smatch warning.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ramkrishna Vepa <ramkrishna.vepa@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Mike Marciniszyn authored and Roland Dreier committed Jul 30, 2012
1 parent 5dedb9f commit 5d7fe4e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/infiniband/hw/qib/qib.h
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,11 @@ struct qib_pportdata {
/* 16 congestion entries with each entry corresponding to a SL */
struct ib_cc_congestion_entry_shadow *congestion_entries;

/* Maximum number of congestion control entries that the agent expects
* the manager to send.
*/
u16 cc_supported_table_entries;

/* Total number of congestion control table entries */
u16 total_cct_entry;

Expand All @@ -667,11 +672,6 @@ struct qib_pportdata {

/* CA's max number of 64 entry units in the congestion control table */
u8 cc_max_table_entries;

/* Maximum number of congestion control entries that the agent expects
* the manager to send.
*/
u8 cc_supported_table_entries;
};

/* Observers. Not to be taken lightly, possibly not to ship. */
Expand Down

0 comments on commit 5d7fe4e

Please sign in to comment.