Skip to content

Commit

Permalink
drm/i915: Only add the lazy request if we end up waiting for it.
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Nov 10, 2010
1 parent 33d2323 commit 5d97eb6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
9 changes: 3 additions & 6 deletions drivers/gpu/drm/i915/i915_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -1664,9 +1664,7 @@ i915_gem_next_request_seqno(struct drm_device *dev,
struct intel_ring_buffer *ring)
{
drm_i915_private_t *dev_priv = dev->dev_private;

ring->outstanding_lazy_request = true;
return dev_priv->next_seqno;
return ring->outstanding_lazy_request = dev_priv->next_seqno;
}

static void
Expand Down Expand Up @@ -2072,7 +2070,7 @@ i915_do_wait_request(struct drm_device *dev, uint32_t seqno,
if (atomic_read(&dev_priv->mm.wedged))
return -EAGAIN;

if (ring->outstanding_lazy_request) {
if (seqno == ring->outstanding_lazy_request) {
struct drm_i915_gem_request *request;

request = kzalloc(sizeof(*request), GFP_KERNEL);
Expand All @@ -2087,7 +2085,6 @@ i915_do_wait_request(struct drm_device *dev, uint32_t seqno,

seqno = request->seqno;
}
BUG_ON(seqno == dev_priv->next_seqno);

if (!i915_seqno_passed(ring->get_seqno(ring), seqno)) {
if (HAS_PCH_SPLIT(dev))
Expand Down Expand Up @@ -3973,7 +3970,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
i915_retire_commands(dev, ring);

if (i915_add_request(dev, file, request, ring))
ring->outstanding_lazy_request = true;
i915_gem_next_request_seqno(dev, ring);
else
request = NULL;

Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_ringbuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ struct intel_ring_buffer {
/**
* Do we have some not yet emitted requests outstanding?
*/
bool outstanding_lazy_request;
u32 outstanding_lazy_request;

wait_queue_head_t irq_queue;
drm_local_map_t map;
Expand Down

0 comments on commit 5d97eb6

Please sign in to comment.