Skip to content

Commit

Permalink
sbs-battery: Don't trigger false supply_changed event
Browse files Browse the repository at this point in the history
power_supply_changed() events are triggerd based on the return value
of a get_property() call. However the property TECHNOLOGY is
hard-coded to LION in this driver, thus always succeeds.

So, with the battery removed, this triggers a false battery present
uevent. This uevent triggers a new query via power_supply_uevent()
which again starts to query all known properties and thus leads to
an infinite loop of battery present/not-present uevents.

This patch skips the battery presence detection for the hard-coded
property TECHNOLOGY.

Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
Acked-by Rhyland Klein <rklein@nvidia.com>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
  • Loading branch information
Nikolaus Voss authored and Anton Vorontsov committed Jun 20, 2012
1 parent ab37813 commit 5da5098
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/power/sbs-battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ static int sbs_get_property(struct power_supply *psy,

case POWER_SUPPLY_PROP_TECHNOLOGY:
val->intval = POWER_SUPPLY_TECHNOLOGY_LION;
break;
goto done; /* don't trigger power_supply_changed()! */

case POWER_SUPPLY_PROP_ENERGY_NOW:
case POWER_SUPPLY_PROP_ENERGY_FULL:
Expand Down

0 comments on commit 5da5098

Please sign in to comment.