Skip to content

Commit

Permalink
ide: disable drive interrupts in ide_driveid_update()
Browse files Browse the repository at this point in the history
Since ide_driveid_update() uses polling to execute the IDENTIFY DEVICE command
but clears nIEN bit in the control register and doesn't mask the IDE interrupt,
the latter does happen and lead to the corresponding message to appear:

ide0: unexpected interrupt, status=0x58, count=1

when e.g. running hdparm with option -X with a non-PCI IDE driver...

Signed-off-by: Mikhail Cherkashin <mcherkashin@ru.mvista.com>
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Mikhail Cherkashin authored and Bartlomiej Zolnierkiewicz committed Jul 15, 2008
1 parent 8c6e46d commit 5ddee51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ide/ide-iops.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ int ide_driveid_update(ide_drive_t *drive)
*/

SELECT_MASK(drive, 1);
ide_set_irq(drive, 1);
ide_set_irq(drive, 0);
msleep(50);
hwif->OUTBSYNC(drive, WIN_IDENTIFY, hwif->io_ports.command_addr);
timeout = jiffies + WAIT_WORSTCASE;
Expand Down

0 comments on commit 5ddee51

Please sign in to comment.