Skip to content

Commit

Permalink
[XFS] Warn on transaction in flight on read-only remount
Browse files Browse the repository at this point in the history
Till VFS can correctly support read-only remount without racing,
use WARN_ON instead of BUG_ON on detecting transaction in flight
after quiescing filesystem.

Signed-off-by: Felix Blyakher <felixb@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
Felix Blyakher committed Jan 27, 2009
1 parent 957274d commit 5e10657
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion fs/xfs/linux-2.6/xfs_sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,11 @@ xfs_quiesce_attr(
/* flush inodes and push all remaining buffers out to disk */
xfs_quiesce_fs(mp);

ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0);
/*
* Just warn here till VFS can correctly support
* read-only remount without racing.
*/
WARN_ON(atomic_read(&mp->m_active_trans) != 0);

/* Push the superblock and write an unmount record */
error = xfs_log_sbcount(mp, 1);
Expand Down

0 comments on commit 5e10657

Please sign in to comment.