Skip to content

Commit

Permalink
[GFS2] Remove unused code from glock layer
Browse files Browse the repository at this point in the history
Remove the unused sync feature from glocks. This is currently done by
calling the required functions to sync pages/blocks directly so this
code isn't needed.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Steven Whitehouse committed Aug 30, 2006
1 parent 8fb4b53 commit 5e2b061
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 12 deletions.
8 changes: 0 additions & 8 deletions fs/gfs2/glock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1296,9 +1296,6 @@ void gfs2_glock_dq(struct gfs2_holder *gh)
struct gfs2_glock *gl = gh->gh_gl;
const struct gfs2_glock_operations *glops = gl->gl_ops;

if (gh->gh_flags & GL_SYNC)
set_bit(GLF_SYNC, &gl->gl_flags);

if (gh->gh_flags & GL_NOCACHE)
handle_callback(gl, LM_ST_UNLOCKED);

Expand All @@ -1313,11 +1310,6 @@ void gfs2_glock_dq(struct gfs2_holder *gh)
if (glops->go_unlock)
glops->go_unlock(gh);

if (test_bit(GLF_SYNC, &gl->gl_flags)) {
if (glops->go_sync)
glops->go_sync(gl, DIO_METADATA | DIO_DATA);
}

gl->gl_stamp = jiffies;

spin_lock(&gl->gl_spin);
Expand Down
1 change: 0 additions & 1 deletion fs/gfs2/glock.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#define GL_SKIP 0x00000100
#define GL_ATIME 0x00000200
#define GL_NOCACHE 0x00000400
#define GL_SYNC 0x00000800
#define GL_NOCANCEL 0x00001000
#define GL_AOP 0x00004000
#define GL_DUMP 0x00008000
Expand Down
2 changes: 0 additions & 2 deletions fs/gfs2/glops.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ static void meta_go_sync(struct gfs2_glock *gl, int flags)
gfs2_ail_empty_gl(gl);
}

clear_bit(GLF_SYNC, &gl->gl_flags);
}

/**
Expand Down Expand Up @@ -236,7 +235,6 @@ static void inode_go_sync(struct gfs2_glock *gl, int flags)
gfs2_ail_empty_gl(gl);
}

clear_bit(GLF_SYNC, &gl->gl_flags);
}

/**
Expand Down
1 change: 0 additions & 1 deletion fs/gfs2/incore.h
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ enum {
GLF_LOCK = 1,
GLF_STICKY = 2,
GLF_PREFETCH = 3,
GLF_SYNC = 4,
GLF_DIRTY = 5,
GLF_SKIP_WAITERS2 = 6,
GLF_GREEDY = 7,
Expand Down

0 comments on commit 5e2b061

Please sign in to comment.