Skip to content

Commit

Permalink
sh: rework memory limits to work with LMB.
Browse files Browse the repository at this point in the history
This reworks the memory limit handling to tie in through the available
LMB infrastructure. This requires a bit of reordering as we need to have
all of the LMB reservations taken care of prior to establishing the
limits.

While we're at it, the crash kernel reservation semantics are reworked
so that we allocate from the bottom up and reduce the risk of having
to disable the memory limit due to a clash with the crash kernel
reservation.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Paul Mundt committed May 10, 2010
1 parent 19d8f84 commit 5e2ff32
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 45 deletions.
2 changes: 1 addition & 1 deletion arch/sh/include/asm/page.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

extern unsigned long shm_align_mask;
extern unsigned long max_low_pfn, min_low_pfn;
extern unsigned long memory_start, memory_end;
extern unsigned long memory_start, memory_end, memory_limit;

static inline unsigned long
pages_do_alias(unsigned long addr1, unsigned long addr2)
Expand Down
20 changes: 14 additions & 6 deletions arch/sh/kernel/machine_kexec.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ void __init reserve_crashkernel(void)

crash_size = PAGE_ALIGN(crashk_res.end - crashk_res.start + 1);
if (!crashk_res.start) {
crashk_res.start = lmb_alloc(crash_size, PAGE_SIZE);
unsigned long max = lmb_end_of_DRAM() - memory_limit;
crashk_res.start = __lmb_alloc_base(crash_size, PAGE_SIZE, max);
if (!crashk_res.start) {
pr_err("crashkernel allocation failed\n");
goto disable;
Expand All @@ -183,15 +184,22 @@ void __init reserve_crashkernel(void)
}
}

pr_info("Reserving %ldMB of memory at %ldMB "
crashk_res.end = crashk_res.start + crash_size - 1;

/*
* Crash kernel trumps memory limit
*/
if ((lmb_end_of_DRAM() - memory_limit) <= crashk_res.end) {
memory_limit = 0;
pr_info("Disabled memory limit for crashkernel\n");
}

pr_info("Reserving %ldMB of memory at 0x%08lx "
"for crashkernel (System RAM: %ldMB)\n",
(unsigned long)(crash_size >> 20),
(unsigned long)(crashk_res.start >> 20),
(unsigned long)(crashk_res.start),
(unsigned long)(lmb_phys_mem_size() >> 20));

crashk_res.end = crashk_res.start + crash_size - 1;
insert_resource(&iomem_resource, &crashk_res);

return;

disable:
Expand Down
63 changes: 25 additions & 38 deletions arch/sh/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,28 +95,20 @@ unsigned long memory_start;
EXPORT_SYMBOL(memory_start);
unsigned long memory_end = 0;
EXPORT_SYMBOL(memory_end);
unsigned long memory_limit = 0;

static struct resource mem_resources[MAX_NUMNODES];

int l1i_cache_shape, l1d_cache_shape, l2_cache_shape;

static int __init early_parse_mem(char *p)
{
unsigned long size;
if (!p)
return 1;

memory_start = (unsigned long)__va(__MEMORY_START);
size = memparse(p, &p);

if (size > __MEMORY_SIZE) {
printk(KERN_ERR
"Using mem= to increase the size of kernel memory "
"is not allowed.\n"
" Recompile the kernel with the correct value for "
"CONFIG_MEMORY_SIZE.\n");
return 0;
}
memory_limit = PAGE_ALIGN(memparse(p, &p));

memory_end = memory_start + size;
pr_notice("Memory limited to %ldMB\n", memory_limit >> 20);

return 0;
}
Expand Down Expand Up @@ -252,7 +244,7 @@ void __init do_init_bootmem(void)
{
unsigned long bootmap_size;
unsigned long bootmap_pages, bootmem_paddr;
u64 total_pages = (lmb_end_of_DRAM() - __MEMORY_START) >> PAGE_SHIFT;
u64 total_pages = lmb_phys_mem_size() >> PAGE_SHIFT;
int i;

bootmap_pages = bootmem_bootmap_pages(total_pages);
Expand All @@ -276,12 +268,6 @@ void __init do_init_bootmem(void)
__add_active_range(0, start_pfn, end_pfn);
}

/*
* Handle additional early reservations
*/
check_for_initrd();
reserve_crashkernel();

/*
* Add all physical memory to the bootmem map and mark each
* area as present.
Expand All @@ -299,7 +285,7 @@ void __init do_init_bootmem(void)
sparse_memory_present_with_active_regions(0);
}

static void __init setup_memory(void)
static void __init early_reserve_mem(void)
{
unsigned long start_pfn;

Expand All @@ -326,11 +312,11 @@ static void __init setup_memory(void)
if (CONFIG_ZERO_PAGE_OFFSET != 0)
lmb_reserve(__MEMORY_START, CONFIG_ZERO_PAGE_OFFSET);

lmb_analyze();
lmb_dump_all();

do_init_bootmem();
plat_mem_setup();
/*
* Handle additional early reservations
*/
check_for_initrd();
reserve_crashkernel();
}

/*
Expand Down Expand Up @@ -397,10 +383,6 @@ void __init setup_arch(char **cmdline_p)
bss_resource.start = virt_to_phys(__bss_start);
bss_resource.end = virt_to_phys(_ebss)-1;

memory_start = (unsigned long)__va(__MEMORY_START);
if (!memory_end)
memory_end = memory_start + __MEMORY_SIZE;

#ifdef CONFIG_CMDLINE_OVERWRITE
strlcpy(command_line, CONFIG_CMDLINE, sizeof(command_line));
#else
Expand All @@ -417,8 +399,6 @@ void __init setup_arch(char **cmdline_p)

parse_early_param();

uncached_init();

plat_early_device_setup();

/* Let earlyprintk output early console messages */
Expand All @@ -429,21 +409,28 @@ void __init setup_arch(char **cmdline_p)
sh_mv_setup();
sh_mv.mv_mem_init();

/*
* Find the highest page frame number we have available
*/
max_pfn = PFN_DOWN(__pa(memory_end));
early_reserve_mem();

lmb_enforce_memory_limit(memory_limit);
lmb_analyze();

lmb_dump_all();

/*
* Determine low and high memory ranges:
*/
max_low_pfn = max_pfn;
max_low_pfn = max_pfn = lmb_end_of_DRAM() >> PAGE_SHIFT;
min_low_pfn = __MEMORY_START >> PAGE_SHIFT;

nodes_clear(node_online_map);

memory_start = (unsigned long)__va(__MEMORY_START);
memory_end = memory_start + (memory_limit ?: lmb_phys_mem_size());

uncached_init();
pmb_init();
setup_memory();
do_init_bootmem();
plat_mem_setup();
sparse_init();

#ifdef CONFIG_DUMMY_CONSOLE
Expand Down

0 comments on commit 5e2ff32

Please sign in to comment.