Skip to content

Commit

Permalink
GFS2: fs/gfs2/glock.c: Use printf extension %pV
Browse files Browse the repository at this point in the history
Using %pV reduces the number of printk calls and
eliminates any possible message interleaving from
other printk calls.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Joe Perches authored and Steven Whitehouse committed Nov 30, 2010
1 parent 2ae51ed commit 5e69069
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions fs/gfs2/glock.c
Original file line number Diff line number Diff line change
Expand Up @@ -951,17 +951,22 @@ int gfs2_glock_wait(struct gfs2_holder *gh)

void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...)
{
struct va_format vaf;
va_list args;

va_start(args, fmt);

if (seq) {
struct gfs2_glock_iter *gi = seq->private;
vsprintf(gi->string, fmt, args);
seq_printf(seq, gi->string);
} else {
printk(KERN_ERR " ");
vprintk(fmt, args);
vaf.fmt = fmt;
vaf.va = &args;

printk(KERN_ERR " %pV", &vaf);
}

va_end(args);
}

Expand Down

0 comments on commit 5e69069

Please sign in to comment.