Skip to content

Commit

Permalink
igb: remove netif running call from igb_poll
Browse files Browse the repository at this point in the history
The netif_running check in igb poll is a hold over from the use of fake
netdevs to use multiple queues with NAPI prior to 2.6.24.  It is no longer
necessary to have the call there and it currently can cause errors if
work_done == budget.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Mar 14, 2009
1 parent 92be791 commit 5e6d5b1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/igb/igb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -4187,7 +4187,6 @@ static int igb_poll(struct napi_struct *napi, int budget)
{
struct igb_ring *rx_ring = container_of(napi, struct igb_ring, napi);
struct igb_adapter *adapter = rx_ring->adapter;
struct net_device *netdev = adapter->netdev;
int work_done = 0;

#ifdef CONFIG_IGB_DCA
Expand All @@ -4206,7 +4205,7 @@ static int igb_poll(struct napi_struct *napi, int budget)
}

/* If not enough Rx work done, exit the polling mode */
if ((work_done < budget) || !netif_running(netdev)) {
if (work_done < budget) {
napi_complete(napi);
igb_rx_irq_enable(rx_ring);
}
Expand Down

0 comments on commit 5e6d5b1

Please sign in to comment.