Skip to content

Commit

Permalink
staging: tidspbridge: remove custom TRUE FALSE
Browse files Browse the repository at this point in the history
bool has standard true and false, we dont need to introduce
our own TRUE and FALSE macros.

Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Nishanth Menon authored and Greg Kroah-Hartman committed Jul 22, 2010
1 parent c8c1ad8 commit 5e76806
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 34 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/tidspbridge/core/tiomap3430.c
Original file line number Diff line number Diff line change
Expand Up @@ -1863,10 +1863,10 @@ bool wait_for_start(struct bridge_dev_context *dev_context, u32 dw_sync_addr)
while (*((volatile u16 *)dw_sync_addr) && --timeout)
udelay(10);

/* If timed out: return FALSE */
/* If timed out: return false */
if (!timeout) {
pr_err("%s: Timed out waiting DSP to Start\n", __func__);
return FALSE;
return false;
}
return TRUE;
return true;
}
3 changes: 0 additions & 3 deletions drivers/staging/tidspbridge/dynload/dload_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
* Internal state definitions for the dynamic loader
*/

#define TRUE 1
#define FALSE 0

/* type used for relocation intermediate results */
typedef s32 rvalue;

Expand Down
2 changes: 0 additions & 2 deletions drivers/staging/tidspbridge/dynload/header.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
*/

#define TRUE 1
#define FALSE 0
#ifndef NULL
#define NULL 0
#endif
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/tidspbridge/gen/gb.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ bool gb_test(struct gb_t_map *map, u32 bitn)

mask = 1L << (bitn % BITS_PER_LONG);
word = map->words[bitn / BITS_PER_LONG];
state = word & mask ? TRUE : FALSE;
state = word & mask ? true : false;

return state;
}
10 changes: 0 additions & 10 deletions drivers/staging/tidspbridge/hw/GlobalTypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,6 @@
#ifndef _GLOBALTYPES_H
#define _GLOBALTYPES_H

/*
* Definition: TRUE, FALSE
*
* DESCRIPTION: Boolean Definitions
*/
#ifndef TRUE
#define FALSE 0
#define TRUE (!(FALSE))
#endif

/*
* Definition: NULL
*
Expand Down
11 changes: 0 additions & 11 deletions drivers/staging/tidspbridge/include/dspbridge/dbtype.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,6 @@
#define CONST const
#endif

/*===========================================================================*/
/* Boolean constants */
/*===========================================================================*/

#ifndef FALSE
#define FALSE 0
#endif
#ifndef TRUE
#define TRUE 1
#endif

/*===========================================================================*/
/* NULL (Definition is language specific) */
/*===========================================================================*/
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/tidspbridge/pmgr/dbll.c
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,7 @@ static int dbll_rmm_alloc(struct dynamic_loader_allocate *this,
int status = 0;
u32 mem_sect_type;
struct rmm_addr rmm_addr_obj;
s32 ret = TRUE;
s32 ret = true;
unsigned stype = DLOAD_SECTION_TYPE(info->type);
char *token = NULL;
char *sz_sec_last_token = NULL;
Expand Down Expand Up @@ -1315,7 +1315,7 @@ static int dbll_rmm_alloc(struct dynamic_loader_allocate *this,
rmm_handle, mem_sect_type,
alloc_size, align,
(u32 *) &rmm_addr_obj,
seg_id, req, FALSE);
seg_id, req, false);
}
if (DSP_FAILED(status)) {
ret = false;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/tidspbridge/pmgr/dmm.c
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ u32 dmm_mem_map_dump(struct dmm_object *dmm_mgr)
for (i = 0; i < table_size; i +=
virtual_mapping_table[i].region_size) {
curr_node = virtual_mapping_table + i;
if (curr_node->reserved == TRUE) {
if (curr_node->reserved) {
/*printk("RESERVED size = 0x%x, "
"Map size = 0x%x\n",
(curr_node->region_size * PG_SIZE4K),
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/tidspbridge/rmgr/node.c
Original file line number Diff line number Diff line change
Expand Up @@ -2620,7 +2620,7 @@ static void delete_node(struct node_object *hnode,

/* Free all SM address translator resources */
if (xlator) {
(void)cmm_xlator_delete(xlator, TRUE); /* force free */
(void)cmm_xlator_delete(xlator, true); /* force free */
xlator = NULL;
}

Expand Down

0 comments on commit 5e76806

Please sign in to comment.