Skip to content

Commit

Permalink
V4L/DVB (8428): videodev: rename 'dev' to 'parent'
Browse files Browse the repository at this point in the history
The field 'dev' is not the video device, but the parent of the video device.
Rename accordingly.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Jul 23, 2008
1 parent 27a5e6d commit 5e85e73
Show file tree
Hide file tree
Showing 25 changed files with 32 additions and 32 deletions.
4 changes: 2 additions & 2 deletions drivers/media/video/bt8xx/bttv-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ static ssize_t show_card(struct device *cd,
struct device_attribute *attr, char *buf)
{
struct video_device *vfd = container_of(cd, struct video_device, class_dev);
struct bttv *btv = dev_get_drvdata(vfd->dev);
struct bttv *btv = dev_get_drvdata(vfd->parent);
return sprintf(buf, "%d\n", btv ? btv->c.type : UNSET);
}
static DEVICE_ATTR(card, S_IRUGO, show_card, NULL);
Expand Down Expand Up @@ -4185,7 +4185,7 @@ static struct video_device *vdev_init(struct bttv *btv,
return NULL;
*vfd = *template;
vfd->minor = -1;
vfd->dev = &btv->c.pci->dev;
vfd->parent = &btv->c.pci->dev;
vfd->release = video_device_release;
vfd->type = type;
vfd->debug = bttv_debug;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cafe_ccic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2157,7 +2157,7 @@ static int cafe_pci_probe(struct pci_dev *pdev,
cam->v4ldev = cafe_v4l_template;
cam->v4ldev.debug = 0;
// cam->v4ldev.debug = V4L2_DEBUG_IOCTL_ARG;
cam->v4ldev.dev = &pdev->dev;
cam->v4ldev.parent = &pdev->dev;
ret = video_register_device(&cam->v4ldev, VFL_TYPE_GRABBER, -1);
if (ret)
goto out_smbus;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx18/cx18-streams.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ static int cx18_prep_dev(struct cx18 *cx, int type)
cx->num);

s->v4l2dev->minor = minor;
s->v4l2dev->dev = &cx->dev->dev;
s->v4l2dev->parent = &cx->dev->dev;
s->v4l2dev->fops = cx18_stream_info[type].fops;
s->v4l2dev->release = video_device_release;
s->v4l2dev->tvnorms = V4L2_STD_ALL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx23885/cx23885-417.c
Original file line number Diff line number Diff line change
Expand Up @@ -1766,7 +1766,7 @@ static struct video_device *cx23885_video_dev_alloc(
vfd->minor = -1;
snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)", dev->name,
type, cx23885_boards[tsport->dev->board].name);
vfd->dev = &pci->dev;
vfd->parent = &pci->dev;
vfd->release = video_device_release;
return vfd;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx23885/cx23885-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ struct video_device *cx23885_vdev_init(struct cx23885_dev *dev,
return NULL;
*vfd = *template;
vfd->minor = -1;
vfd->dev = &pci->dev;
vfd->parent = &pci->dev;
vfd->release = video_device_release;
snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)",
dev->name, type, cx23885_boards[dev->board].name);
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/cx88/cx88-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ struct video_device *cx88_vdev_init(struct cx88_core *core,
return NULL;
*vfd = *template;
vfd->minor = -1;
vfd->dev = &pci->dev;
vfd->parent = &pci->dev;
vfd->release = video_device_release;
snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)",
core->name, type, core->board.name);
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/em28xx/em28xx-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1892,7 +1892,7 @@ static struct video_device *em28xx_vdev_init(struct em28xx *dev,
return NULL;
*vfd = *template;
vfd->minor = -1;
vfd->dev = &dev->udev->dev;
vfd->parent = &dev->udev->dev;
vfd->release = video_device_release;
vfd->type = type;
vfd->debug = video_debug;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/gspca/gspca.c
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@ int gspca_dev_probe(struct usb_interface *intf,

/* init video stuff */
memcpy(&gspca_dev->vdev, &gspca_template, sizeof gspca_template);
gspca_dev->vdev.dev = &dev->dev;
gspca_dev->vdev.parent = &dev->dev;
memcpy(&gspca_dev->fops, &dev_fops, sizeof gspca_dev->fops);
gspca_dev->vdev.fops = &gspca_dev->fops;
gspca_dev->fops.owner = module; /* module protection */
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/ivtv/ivtv-streams.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ static int ivtv_prep_dev(struct ivtv *itv, int type)
itv->num, s->name);

s->v4l2dev->minor = minor;
s->v4l2dev->dev = &itv->dev->dev;
s->v4l2dev->parent = &itv->dev->dev;
s->v4l2dev->fops = ivtv_stream_info[type].fops;
s->v4l2dev->release = video_device_release;
s->v4l2dev->tvnorms = V4L2_STD_ALL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/meye.c
Original file line number Diff line number Diff line change
Expand Up @@ -1801,7 +1801,7 @@ static int __devinit meye_probe(struct pci_dev *pcidev,
}

memcpy(meye.video_dev, &meye_template, sizeof(meye_template));
meye.video_dev->dev = &meye.mchip_dev->dev;
meye.video_dev->parent = &meye.mchip_dev->dev;

if ((ret = sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERA, 1))) {
printk(KERN_ERR "meye: unable to power on the camera\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/mt9m001.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ static int mt9m001_init(struct soc_camera_device *icd)
int ret;

/* Disable chip, synchronous option update */
dev_dbg(icd->vdev->dev, "%s\n", __func__);
dev_dbg(icd->vdev->parent, "%s\n", __func__);

ret = reg_write(icd, MT9M001_RESET, 1);
if (ret >= 0)
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/ov511.c
Original file line number Diff line number Diff line change
Expand Up @@ -5833,7 +5833,7 @@ ov51x_probe(struct usb_interface *intf, const struct usb_device_id *id)
goto error;

memcpy(ov->vdev, &vdev_template, sizeof(*ov->vdev));
ov->vdev->dev = &intf->dev;
ov->vdev->parent = &intf->dev;
video_set_drvdata(ov->vdev, ov);

for (i = 0; i < OV511_MAX_UNIT_VIDEO; i++) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/pwc/pwc-if.c
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
return -ENOMEM;
}
memcpy(pdev->vdev, &pwc_template, sizeof(pwc_template));
pdev->vdev->dev = &(udev->dev);
pdev->vdev->parent = &(udev->dev);
strcpy(pdev->vdev->name, name);
pdev->vdev->owner = THIS_MODULE;
video_set_drvdata(pdev->vdev, pdev);
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/s2255drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1706,7 +1706,7 @@ static int s2255_probe_v4l(struct s2255_dev *dev)
/* register 4 video devices */
dev->vdev[i] = video_device_alloc();
memcpy(dev->vdev[i], &template, sizeof(struct video_device));
dev->vdev[i]->dev = &dev->interface->dev;
dev->vdev[i]->parent = &dev->interface->dev;
if (video_nr == -1)
ret = video_register_device(dev->vdev[i],
VFL_TYPE_GRABBER,
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/saa7134/saa7134-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ static struct video_device *vdev_init(struct saa7134_dev *dev,
return NULL;
*vfd = *template;
vfd->minor = -1;
vfd->dev = &dev->pci->dev;
vfd->parent = &dev->pci->dev;
vfd->release = video_device_release;
vfd->debug = video_debug;
snprintf(vfd->name, sizeof(vfd->name), "%s %s (%s)",
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/saa7134/saa7134-empress.c
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ static int empress_init(struct saa7134_dev *dev)
if (NULL == dev->empress_dev)
return -ENOMEM;
*(dev->empress_dev) = saa7134_empress_template;
dev->empress_dev->dev = &dev->pci->dev;
dev->empress_dev->parent = &dev->pci->dev;
dev->empress_dev->release = video_device_release;
snprintf(dev->empress_dev->name, sizeof(dev->empress_dev->name),
"%s empress (%s)", dev->name,
Expand Down
10 changes: 5 additions & 5 deletions drivers/media/video/soc_camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ static int soc_camera_open(struct inode *inode, struct file *file)
mutex_lock(&video_lock);

vdev = video_devdata(file);
icd = container_of(vdev->dev, struct soc_camera_device, dev);
icd = container_of(vdev->parent, struct soc_camera_device, dev);
ici = to_soc_camera_host(icd->dev.parent);

if (!try_module_get(icd->ops->owner)) {
Expand Down Expand Up @@ -258,7 +258,7 @@ static int soc_camera_close(struct inode *inode, struct file *file)

vfree(icf);

dev_dbg(vdev->dev, "camera device close\n");
dev_dbg(vdev->parent, "camera device close\n");

return 0;
}
Expand All @@ -271,7 +271,7 @@ static ssize_t soc_camera_read(struct file *file, char __user *buf,
struct video_device *vdev = icd->vdev;
int err = -EINVAL;

dev_err(vdev->dev, "camera device read not implemented\n");
dev_err(vdev->parent, "camera device read not implemented\n");

return err;
}
Expand Down Expand Up @@ -877,7 +877,7 @@ int soc_camera_video_start(struct soc_camera_device *icd)

strlcpy(vdev->name, ici->drv_name, sizeof(vdev->name));
/* Maybe better &ici->dev */
vdev->dev = &icd->dev;
vdev->parent = &icd->dev;
vdev->type = VID_TYPE_CAPTURE;
vdev->current_norm = V4L2_STD_UNKNOWN;
vdev->fops = &soc_camera_fops;
Expand Down Expand Up @@ -915,7 +915,7 @@ int soc_camera_video_start(struct soc_camera_device *icd)

err = video_register_device(vdev, VFL_TYPE_GRABBER, vdev->minor);
if (err < 0) {
dev_err(vdev->dev, "video_register_device failed\n");
dev_err(vdev->parent, "video_register_device failed\n");
goto evidregd;
}
icd->vdev = vdev;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/stk-webcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,7 @@ static int stk_register_video_device(struct stk_camera *dev)

dev->vdev = stk_v4l_data;
dev->vdev.debug = debug;
dev->vdev.dev = &dev->interface->dev;
dev->vdev.parent = &dev->interface->dev;
dev->vdev.priv = dev;
err = video_register_device(&dev->vdev, VFL_TYPE_GRABBER, -1);
if (err)
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/stv680.c
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ static int stv680_probe (struct usb_interface *intf, const struct usb_device_id
goto error;
}
memcpy(stv680->vdev, &stv680_template, sizeof(stv680_template));
stv680->vdev->dev = &intf->dev;
stv680->vdev->parent = &intf->dev;
video_set_drvdata(stv680->vdev, stv680);

memcpy (stv680->vdev->name, stv680->camera_name, strlen (stv680->camera_name));
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/usbvideo/usbvideo.c
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ int usbvideo_RegisterVideoDevice(struct uvd *uvd)
err("%s: uvd->dev == NULL", __func__);
return -EINVAL;
}
uvd->vdev.dev = &uvd->dev->dev;
uvd->vdev.parent = &uvd->dev->dev;
if (video_register_device(&uvd->vdev, VFL_TYPE_GRABBER, video_nr) == -1) {
err("%s: video_register_device failed", __func__);
return -EPIPE;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/usbvision/usbvision-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,7 @@ static struct video_device *usbvision_vdev_init(struct usb_usbvision *usbvision,
}
*vdev = *vdev_template;
// vdev->minor = -1;
vdev->dev = &usb_dev->dev;
vdev->parent = &usb_dev->dev;
snprintf(vdev->name, sizeof(vdev->name), "%s", name);
video_set_drvdata(vdev, usbvision);
return vdev;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/uvc/uvc_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ static int uvc_register_video(struct uvc_device *dev)
* unregistered before the reference is released, so we don't need to
* get another one.
*/
vdev->dev = &dev->intf->dev;
vdev->parent = &dev->intf->dev;
vdev->type = 0;
vdev->type2 = 0;
vdev->minor = -1;
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/video/v4l2-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ static int get_index(struct video_device *vdev, int num)
for (i = 0; i < VIDEO_NUM_DEVICES; i++) {
if (video_device[i] != NULL &&
video_device[i] != vdev &&
video_device[i]->dev == vdev->dev) {
video_device[i]->parent == vdev->parent) {
used |= 1 << video_device[i]->index;
}
}
Expand Down Expand Up @@ -323,8 +323,8 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,
memset(&vfd->class_dev, 0x00, sizeof(vfd->class_dev));
vfd->class_dev.class = &video_class;
vfd->class_dev.devt = MKDEV(VIDEO_MAJOR, vfd->minor);
if (vfd->dev)
vfd->class_dev.parent = vfd->dev;
if (vfd->parent)
vfd->class_dev.parent = vfd->parent;
sprintf(vfd->class_dev.bus_id, "%s%d", name_base, i - base);
ret = device_register(&vfd->class_dev);
if (ret < 0) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/w9968cf.c
Original file line number Diff line number Diff line change
Expand Up @@ -3555,7 +3555,7 @@ w9968cf_usb_probe(struct usb_interface* intf, const struct usb_device_id* id)
cam->v4ldev->minor = video_nr[dev_nr];
cam->v4ldev->release = video_device_release;
video_set_drvdata(cam->v4ldev, cam);
cam->v4ldev->dev = &cam->dev;
cam->v4ldev->parent = &cam->dev;

err = video_register_device(cam->v4ldev, VFL_TYPE_GRABBER,
video_nr[dev_nr]);
Expand Down
2 changes: 1 addition & 1 deletion include/media/v4l2-dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ struct video_device

/* sysfs */
struct device class_dev; /* v4l device */
struct device *dev; /* device parent */
struct device *parent; /* device parent */

/* device info */
char name[32];
Expand Down

0 comments on commit 5e85e73

Please sign in to comment.