Skip to content

Commit

Permalink
uvesafb: small cleanups
Browse files Browse the repository at this point in the history
Some cleanups in uvesafb:
- The custom module_param() get/set functions don't need to be inlined
  since it is referred to via a pointer in a struct.
- don't end a #define with a ';'
- remove one of the single quote marks in "''ypan'"

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Michal Januszewski <spock@gentoo.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Randy Dunlap authored and Linus Torvalds committed Feb 6, 2008
1 parent 0ce85eb commit 5eb03a4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/video/uvesafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2003,12 +2003,12 @@ static void __devexit uvesafb_exit(void)

module_exit(uvesafb_exit);

static inline int param_get_scroll(char *buffer, struct kernel_param *kp)
static int param_get_scroll(char *buffer, struct kernel_param *kp)
{
return 0;
}

static inline int param_set_scroll(const char *val, struct kernel_param *kp)
static int param_set_scroll(const char *val, struct kernel_param *kp)
{
ypan = 0;

Expand All @@ -2022,11 +2022,11 @@ static inline int param_set_scroll(const char *val, struct kernel_param *kp)
return 0;
}

#define param_check_scroll(name, p) __param_check(name, p, void);
#define param_check_scroll(name, p) __param_check(name, p, void)

module_param_named(scroll, ypan, scroll, 0);
MODULE_PARM_DESC(scroll,
"Scrolling mode, set to 'redraw', ''ypan' or 'ywrap'");
"Scrolling mode, set to 'redraw', 'ypan', or 'ywrap'");
module_param_named(vgapal, pmi_setpal, invbool, 0);
MODULE_PARM_DESC(vgapal, "Set palette using VGA registers");
module_param_named(pmipal, pmi_setpal, bool, 0);
Expand Down

0 comments on commit 5eb03a4

Please sign in to comment.