Skip to content

Commit

Permalink
leds: lp5523: Fix return value
Browse files Browse the repository at this point in the history
Return the value obtained from i2c_smbus_read_byte_data() instead of
-EIO. Silences the following smatch warning:
drivers/leds/leds-lp5523.c:174 lp5523_read() info:
why not propagate 'ret' from i2c_smbus_read_byte_data() instead of -5?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
  • Loading branch information
Sachin Kamat authored and Bryan Wu committed Nov 26, 2012
1 parent 313e8b5 commit 5ebab74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/leds/leds-lp5523.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ static int lp5523_read(struct i2c_client *client, u8 reg, u8 *buf)
s32 ret = i2c_smbus_read_byte_data(client, reg);

if (ret < 0)
return -EIO;
return ret;

*buf = ret;
return 0;
Expand Down

0 comments on commit 5ebab74

Please sign in to comment.