Skip to content

Commit

Permalink
V4L/DVB (11235): changed ioctls to unlocked
Browse files Browse the repository at this point in the history
Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Stoyan Gaydarov authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent cea0213 commit 5ed2b64
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
7 changes: 5 additions & 2 deletions drivers/media/dvb/bt8xx/dst_ca.c
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,10 @@ static int ca_send_message(struct dst_state *state, struct ca_msg *p_ca_message,
return result;
}

static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long ioctl_arg)
static long dst_ca_ioctl(struct file *file, unsigned int cmd, unsigned long ioctl_arg)
{
lock_kernel();

struct dvb_device* dvbdev = (struct dvb_device*) file->private_data;
struct dst_state* state = (struct dst_state*) dvbdev->priv;
struct ca_slot_info *p_ca_slot_info;
Expand Down Expand Up @@ -647,6 +649,7 @@ static int dst_ca_ioctl(struct inode *inode, struct file *file, unsigned int cmd
kfree (p_ca_slot_info);
kfree (p_ca_caps);

unlock_kernel();
return result;
}

Expand Down Expand Up @@ -684,7 +687,7 @@ static ssize_t dst_ca_write(struct file *file, const char __user *buffer, size_t

static const struct file_operations dst_ca_fops = {
.owner = THIS_MODULE,
.ioctl = dst_ca_ioctl,
.unlocked_ioctl = dst_ca_ioctl,
.open = dst_ca_open,
.release = dst_ca_release,
.read = dst_ca_read,
Expand Down
11 changes: 8 additions & 3 deletions drivers/media/video/dabusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -673,22 +673,26 @@ static int dabusb_release (struct inode *inode, struct file *file)
return 0;
}

static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
static long dabusb_ioctl (struct file *file, unsigned int cmd, unsigned long arg)
{
lock_kernel();
pdabusb_t s = (pdabusb_t) file->private_data;
pbulk_transfer_t pbulk;
int ret = 0;
int version = DABUSB_VERSION;

dbg("dabusb_ioctl");

if (s->remove_pending)
if (s->remove_pending) {
unlock_kernel();
return -EIO;
}

mutex_lock(&s->mutex);

if (!s->usbdev) {
mutex_unlock(&s->mutex);
unlock_kernel();
return -EIO;
}

Expand Down Expand Up @@ -729,6 +733,7 @@ static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cm
break;
}
mutex_unlock(&s->mutex);
unlock_kernel();
return ret;
}

Expand All @@ -737,7 +742,7 @@ static const struct file_operations dabusb_fops =
.owner = THIS_MODULE,
.llseek = no_llseek,
.read = dabusb_read,
.ioctl = dabusb_ioctl,
.unlocked_ioctl = dabusb_ioctl,
.open = dabusb_open,
.release = dabusb_release,
};
Expand Down

0 comments on commit 5ed2b64

Please sign in to comment.