Skip to content

Commit

Permalink
ACPI: hotkey: remove driver, per feature-removal-schedule.txt
Browse files Browse the repository at this point in the history
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Feb 17, 2007
1 parent eaefd5f commit 5ee6edb
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 1,148 deletions.
38 changes: 0 additions & 38 deletions Documentation/acpi-hotkey.txt

This file was deleted.

23 changes: 0 additions & 23 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -246,29 +246,6 @@ Who: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

---------------------------

<<<<<<< test:Documentation/feature-removal-schedule.txt
What: ACPI hotkey driver (CONFIG_ACPI_HOTKEY)
When: 2.6.21
Why: hotkey.c was an attempt to consolidate multiple drivers that use
ACPI to implement hotkeys. However, hotkeys are not documented
in the ACPI specification, so the drivers used undocumented
vendor-specific hooks and turned out to be more different than
the same.

Further, the keys and the features supplied by each platform
are different, so there will always be a need for
platform-specific drivers.

So the new plan is to delete hotkey.c and instead, work on the
platform specific drivers to try to make them look the same
to the user when they supply the same features.

hotkey.c has always depended on CONFIG_EXPERIMENTAL

Who: Len Brown <len.brown@intel.com>

---------------------------

What: /sys/firmware/acpi/namespace
When: 2.6.21
Why: The ACPI namespace is effectively the symbol list for
Expand Down
9 changes: 0 additions & 9 deletions drivers/acpi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,6 @@ config ACPI_VIDEO
Note that this is an ref. implementation only. It may or may not work
for your integrated video device.

config ACPI_HOTKEY
tristate "Generic Hotkey (EXPERIMENTAL)"
depends on EXPERIMENTAL
depends on X86
default n
help
Experimental consolidated hotkey driver.
If you are unsure, say N.

config ACPI_FAN
tristate "Fan"
default y
Expand Down
1 change: 0 additions & 1 deletion drivers/acpi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ obj-$(CONFIG_ACPI_FAN) += fan.o
obj-$(CONFIG_ACPI_DOCK) += dock.o
obj-$(CONFIG_ACPI_BAY) += bay.o
obj-$(CONFIG_ACPI_VIDEO) += video.o
obj-$(CONFIG_ACPI_HOTKEY) += hotkey.o
obj-y += pci_root.o pci_link.o pci_irq.o pci_bind.o
obj-$(CONFIG_ACPI_POWER) += power.o
obj-$(CONFIG_ACPI_PROCESSOR) += processor.o
Expand Down
4 changes: 0 additions & 4 deletions drivers/acpi/asus_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1365,10 +1365,6 @@ static int __init asus_acpi_init(void)
if (acpi_disabled)
return -ENODEV;

if (!acpi_specific_hotkey_enabled) {
printk(KERN_ERR "Using generic hotkey driver\n");
return -ENODEV;
}
asus_proc_dir = proc_mkdir(PROC_ASUS, acpi_root_dir);
if (!asus_proc_dir) {
printk(KERN_ERR "Asus ACPI: Unable to create /proc entry\n");
Expand Down
Loading

0 comments on commit 5ee6edb

Please sign in to comment.