Skip to content

Commit

Permalink
ptrace: cleanup arch_ptrace() on xtensa
Browse files Browse the repository at this point in the history
Use new 'datap' variable in order to remove unnecessary castings.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Chris Zankel <chris@zankel.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Namhyung Kim authored and Linus Torvalds committed Oct 28, 2010
1 parent 0a3d763 commit 5ef4507
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions arch/xtensa/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ long arch_ptrace(struct task_struct *child, long request,
unsigned long addr, unsigned long data)
{
int ret = -EPERM;
void __user *datap = (void __user *) data;

switch (request) {
case PTRACE_PEEKTEXT: /* read word at location addr. */
Expand All @@ -268,7 +269,7 @@ long arch_ptrace(struct task_struct *child, long request,
break;

case PTRACE_PEEKUSR: /* read register specified by addr. */
ret = ptrace_peekusr(child, addr, (void __user *) data);
ret = ptrace_peekusr(child, addr, datap);
break;

case PTRACE_POKETEXT: /* write the word at location addr. */
Expand All @@ -281,19 +282,19 @@ long arch_ptrace(struct task_struct *child, long request,
break;

case PTRACE_GETREGS:
ret = ptrace_getregs(child, (void __user *) data);
ret = ptrace_getregs(child, datap);
break;

case PTRACE_SETREGS:
ret = ptrace_setregs(child, (void __user *) data);
ret = ptrace_setregs(child, datap);
break;

case PTRACE_GETXTREGS:
ret = ptrace_getxregs(child, (void __user *) data);
ret = ptrace_getxregs(child, datap);
break;

case PTRACE_SETXTREGS:
ret = ptrace_setxregs(child, (void __user *) data);
ret = ptrace_setxregs(child, datap);
break;

default:
Expand Down

0 comments on commit 5ef4507

Please sign in to comment.