Skip to content

Commit

Permalink
[POWERPC] Sky Cpu and Nexus: check for create_proc_entry ret code
Browse files Browse the repository at this point in the history
Adds checking of create_proc_entry call to prevent possible NULL
pointer usage.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Cyrill Gorcunov authored and Paul Mackerras committed Oct 3, 2007
1 parent 7472fd3 commit 5f725fe
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions drivers/misc/hdpuftrs/hdpu_nexus.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,20 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
}

hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root);
hdpu_slot_id->read_proc = hdpu_slot_id_read;
if (!hdpu_slot_id) {
printk(KERN_WARNING "sky_nexus: "
"Unable to create proc dir entry: sky_slot_id\n");
} else {
hdpu_slot_id->read_proc = hdpu_slot_id_read;
}

hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root);
hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
if (!hdpu_chassis_id) {
printk(KERN_WARNING "sky_nexus: "
"Unable to create proc dir entry: sky_chassis_id\n");
} else {
hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
}

return 0;
}
Expand Down

0 comments on commit 5f725fe

Please sign in to comment.