Skip to content

Commit

Permalink
um: net: Eliminate NULL test after alloc_bootmem
Browse files Browse the repository at this point in the history
alloc_bootmem and related functions never return NULL. Thus a NULL
test or memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E;
statement S;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
... when != E
- if (E == NULL) S

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Richard Weinberger <richard@nod.at>
  • Loading branch information
Himangi Saraogi authored and Richard Weinberger committed Oct 13, 2014
1 parent 970e51f commit 5f78659
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions arch/um/drivers/net_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,10 +659,6 @@ static int __init eth_setup(char *str)
}

new = alloc_bootmem(sizeof(*new));
if (new == NULL) {
printk(KERN_ERR "eth_init : alloc_bootmem failed\n");
return 1;
}

INIT_LIST_HEAD(&new->list);
new->index = n;
Expand Down

0 comments on commit 5f78659

Please sign in to comment.