Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 147563
b: refs/heads/master
c: 69ee69f
h: refs/heads/master
i:
  147561: 3c2d631
  147559: ba41e52
v: v3
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed May 28, 2009
1 parent 3f79227 commit 5f8f8c6
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: a827c875f2ebe69c6e6db5e7f112d4beb4d80f01
refs/heads/master: 69ee69f63c82e63d9c6c6081d12673af4933c51e
4 changes: 2 additions & 2 deletions trunk/Documentation/perf_counter/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ static struct dso *dsos__findnew(const char *name)
if (!dso)
goto out_delete_dso;

nr = dso__load(dso);
nr = dso__load(dso, NULL);
if (nr < 0) {
fprintf(stderr, "Failed to open: %s\n", name);
goto out_delete_dso;
Expand Down Expand Up @@ -124,7 +124,7 @@ static int load_kernel(void)
if (!kernel_dso)
return -1;

err = dso__load_kernel(kernel_dso, vmlinux);
err = dso__load_kernel(kernel_dso, vmlinux, NULL);
if (err) {
dso__delete(kernel_dso);
kernel_dso = NULL;
Expand Down
34 changes: 21 additions & 13 deletions trunk/Documentation/perf_counter/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ static int hex2long(char *ptr, unsigned long *long_val)
return p - ptr;
}

static int dso__load_kallsyms(struct dso *self)
static int dso__load_kallsyms(struct dso *self, symbol_filter_t filter)
{
struct rb_node *nd, *prevnd;
char *line = NULL;
Expand Down Expand Up @@ -201,7 +201,10 @@ static int dso__load_kallsyms(struct dso *self)
if (sym == NULL)
goto out_delete_line;

dso__insert_symbol(self, sym);
if (filter && filter(self, sym))
symbol__delete(sym, self->sym_priv_size);
else
dso__insert_symbol(self, sym);
}

/*
Expand Down Expand Up @@ -286,7 +289,8 @@ static Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep,
return sec;
}

static int dso__load_sym(struct dso *self, int fd, const char *name)
static int dso__load_sym(struct dso *self, int fd, const char *name,
symbol_filter_t filter)
{
Elf_Data *symstrs;
uint32_t nr_syms;
Expand Down Expand Up @@ -352,9 +356,12 @@ static int dso__load_sym(struct dso *self, int fd, const char *name)
if (!f)
goto out_elf_end;

dso__insert_symbol(self, f);

nr++;
if (filter && filter(self, f))
symbol__delete(f, self->sym_priv_size);
else {
dso__insert_symbol(self, f);
nr++;
}
}

err = nr;
Expand All @@ -364,7 +371,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name)
return err;
}

int dso__load(struct dso *self)
int dso__load(struct dso *self, symbol_filter_t filter)
{
int size = strlen(self->name) + sizeof("/usr/lib/debug%s.debug");
char *name = malloc(size);
Expand Down Expand Up @@ -396,7 +403,7 @@ int dso__load(struct dso *self)
fd = open(name, O_RDONLY);
} while (fd < 0);

ret = dso__load_sym(self, fd, name);
ret = dso__load_sym(self, fd, name, filter);
close(fd);

/*
Expand All @@ -410,28 +417,29 @@ int dso__load(struct dso *self)
return ret;
}

static int dso__load_vmlinux(struct dso *self, const char *vmlinux)
static int dso__load_vmlinux(struct dso *self, const char *vmlinux,
symbol_filter_t filter)
{
int err, fd = open(vmlinux, O_RDONLY);

if (fd < 0)
return -1;

err = dso__load_sym(self, fd, vmlinux);
err = dso__load_sym(self, fd, vmlinux, filter);
close(fd);

return err;
}

int dso__load_kernel(struct dso *self, const char *vmlinux)
int dso__load_kernel(struct dso *self, const char *vmlinux, symbol_filter_t filter)
{
int err = -1;

if (vmlinux)
err = dso__load_vmlinux(self, vmlinux);
err = dso__load_vmlinux(self, vmlinux, filter);

if (err)
err = dso__load_kallsyms(self);
err = dso__load_kallsyms(self, filter);

return err;
}
Expand Down
7 changes: 5 additions & 2 deletions trunk/Documentation/perf_counter/util/symbol.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ struct dso {
char name[0];
};

typedef int (*symbol_filter_t)(struct dso *self, struct symbol *sym);

struct dso *dso__new(const char *name, unsigned int sym_priv_size);
void dso__delete(struct dso *self);

Expand All @@ -29,8 +31,9 @@ static inline void *dso__sym_priv(struct dso *self, struct symbol *sym)

struct symbol *dso__find_symbol(struct dso *self, uint64_t ip);

int dso__load_kernel(struct dso *self, const char *vmlinux);
int dso__load(struct dso *self);
int dso__load_kernel(struct dso *self, const char *vmlinux,
symbol_filter_t filter);
int dso__load(struct dso *self, symbol_filter_t filter);

size_t dso__fprintf(struct dso *self, FILE *fp);

Expand Down

0 comments on commit 5f8f8c6

Please sign in to comment.